Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8643] - Move Breadcrumb to linode/ui package #11329

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

hasyed-akamai
Copy link
Contributor

Description πŸ“

Migrate Breadcrumb to linode/ui package.

Target release date πŸ—“οΈ

N/A

How to test πŸ§ͺ

  • All tests should pass
  • There should be no adverse impacts observed in Cloud

Check all that apply

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/Improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

import { EditableProps, LabelProps } from './types';

import type { EditableProps, LabelProps } from './types';
import type { LocationDescriptor } from 'history';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ we should see if we can eliminate the need for history. We don't want our UI package to depend on extra things if possible

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸŽ‰ 466 passing tests on test run #3 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
0 Failing466 Passing2 Skipped102m 43s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants